Stake releasing for withdraw request

l00k · 28 September 2021 07:05

I have concern about withdrawing stake from pool.
Let say someone requested withdrawal from my pool.
I don’t have funds to delegate and fullfit his request only option
I have is to stop miner - but after that funds are not free - they are in releasing state (for 7 days)
So still I will not have funds on time and all my workers will be stopped.

Is that intended?
Or am I missing something?

I have read about that 1 Secure Worker Mining and Staking | Phala Network Wiki

The Owner of the StakePool should take care of the Free Delegation, and introduce extra delegation or reduce mining Workers as needed. Or all the Workers in the pool can be forced to stop mining;

but from my observation after I stopped worker funds are not free.

If that is true it creates opportunity to attack pool. Bad actor could stake a lot to pool - wait for his funds been used in mining and request total amount withdraw making entire pool to stop mining after while

zozyo · 28 September 2021 07:54

Tokens in releasing state also count for withdraw.
For example, you stop a miner 1 day later, the guy will get all his token after 1+7 days.

l00k · 28 September 2021 08:10

Ouu that changes a lot. I thought it counts only free amount.
Did you test that?
Cuz it is not directly written in docs

zozyo · 28 September 2021 12:16

One of officials replies me in Chinese channel.

zozyo · 28 September 2021 12:34

Code is here

github.com

Phala-Network/phala-blockchain/blob/7bb43c3a8bc95398d454876ea0fb4a2b7b2f6761/pallets/phala/src/stakepool.rs#L1217

    
      
          			// If we check the pool withdraw_queue here, we don't have to remove a pool from
          			// WithdrawalQueuedPools when a pool has handled their waiting withdraw requests before
          			// timeout. Compare the IO performance we think removing pool from
          			// WithdrawalQueuedPools would have more resource cost.
          
          
			// If the pool is bankrupt, or there's no share, we just skip this pool.
          			let price = match self.share_price() {
          				Some(price) if price != fp!(0) => price,
          				_ => return false,
          			};
          			let mut budget = self.free_stake + self.releasing_stake;
          			for request in &self.withdraw_queue {
          				let amount = bmul(request.shares, &price);
          				if amount > budget {
          					// Run out of budget, let's check if the request is still in the grace period
          					return now - request.start_time > grace_period;
          				} else {
          					// Otherwise we allocate some budget to virtually fulfill the request
          					budget -= amount;
          				}
          			}

l00k · 30 September 2021 13:48

That is kind of answer I like. Source of truth - code.
Thanks

xdggx · 22 October 2021 12:34

hello.I still don’t understand this question, can you teach me?

system · 1 December 2021 14:13

此话题已在最后回复的 2 小时后被自动关闭。不再允许新回复。